Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several edge cases in skin editor gameplay scene opening flow #25665

Merged
merged 10 commits into from
Dec 4, 2023

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Dec 4, 2023

I'm bundling all three fixes together because they're in the same place and small.

All scenarios covered by unit tests. Decisions on what to do in each situations were ad hoc and are generally disputable, I ended up going the easiest route in all cases basically.

An alternative to this that would fix the first two issues could be to revert #25568, if one was to go this way I suppose. The third was present even before that PR.

@peppy peppy enabled auto-merge December 4, 2023 14:07
@bdach bdach disabled auto-merge December 4, 2023 15:48
@bdach bdach merged commit f0364f0 into ppy:master Dec 4, 2023
14 of 16 checks passed
@bdach bdach deleted the skin-editor-breakage branch December 4, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment