Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ManiaHealthProcessor that uses the legacy drain rate algorithm #25587

Merged
merged 1 commit into from
Nov 27, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 45 additions & 7 deletions osu.Game.Rulesets.Mania/Scoring/ManiaHealthProcessor.cs
Original file line number Diff line number Diff line change
@@ -1,23 +1,61 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using osu.Game.Rulesets.Judgements;
using System.Collections.Generic;
using osu.Game.Rulesets.Mania.Objects;
using osu.Game.Rulesets.Objects;
using osu.Game.Rulesets.Scoring;

namespace osu.Game.Rulesets.Mania.Scoring
{
public partial class ManiaHealthProcessor : DrainingHealthProcessor
public partial class ManiaHealthProcessor : LegacyDrainingHealthProcessor
{
/// <inheritdoc/>
public ManiaHealthProcessor(double drainStartTime)
: base(drainStartTime, 1.0)
: base(drainStartTime)
{
}

protected override HitResult GetSimulatedHitResult(Judgement judgement)
protected override IEnumerable<HitObject> EnumerateTopLevelHitObjects() => Beatmap.HitObjects;

protected override IEnumerable<HitObject> EnumerateNestedHitObjects(HitObject hitObject) => hitObject.NestedHitObjects;

protected override double GetHealthIncreaseFor(HitObject hitObject, HitResult result)
{
// Users are not expected to attain perfect judgements for all notes due to the tighter hit window.
return judgement.MaxResult == HitResult.Perfect ? HitResult.Great : judgement.MaxResult;
double increase = 0;

switch (result)
{
case HitResult.Miss:
switch (hitObject)
{
case HeadNote:
case TailNote:
return -(Beatmap.Difficulty.DrainRate + 1) * 0.00375;

default:
return -(Beatmap.Difficulty.DrainRate + 1) * 0.0075;
}

case HitResult.Meh:
return -(Beatmap.Difficulty.DrainRate + 1) * 0.0016;

case HitResult.Ok:
return 0;

case HitResult.Good:
increase = 0.004 - Beatmap.Difficulty.DrainRate * 0.0004;
break;

case HitResult.Great:
increase = 0.005 - Beatmap.Difficulty.DrainRate * 0.0005;
break;

case HitResult.Perfect:
increase = 0.0055 - Beatmap.Difficulty.DrainRate * 0.0005;
break;
}

return HpMultiplierNormal * increase;
}
}
}
Loading