Add CatchHealthProcessor that uses the legacy drain rate algorithm
#25563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
force-pushed
the
catch-hp-drain-v1
branch
from
12951d3 to
bb66267
Compare
peppy
approved these changes
Nov 24, 2023
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same spirit as #25418
This uses the newer/more correct break time calculation from #25420, even though that PR hasn't been merged yet.
Here's a spreadsheet of V1 (legacy implementation with combo ends turned off) vs V2 (non-legacy implementation with breaks fixed): https://docs.google.com/spreadsheets/d/1o3iQhizXZ1RkOShigNgYtkt3NKxDxXrcrqvONSQ_ylY/edit?usp=sharing
This can be tested using https://github.com/smoogipoo/osu-tools/tree/hp-test , but it's pretty hard for anyone without access to stable's codebase to tell whether the numbers are correct.