Fix skin element "PlayerFlag" responding to clicks/hovers #25530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tooltip still shows.
The BaseDrawableFlag is used in a BaseUpdateableFlag so the tooltip is not shown, the ClickableUpdateableFlag still shows the tooltip.
|
That's a lot of over-engineering. Why not just introduce a bool parameter on |
|
Why not just disable subtree input on the skinnable component and avoid all complexity? |
|
That sounds fine as well. |
I'll undo the changes and do that. |
|
Done. Should work now without overengineering. |
peppy
changed the title
peppy
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25529.
Added BaseUpdateableFlag and BaseDrawableFlag classes that don't have tooltips or click functionality.
The UpdateableFlag class was renamed to ClickableUpdateableFlag.