Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to make cursor show even during touch input #19389

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 26, 2022

I completely disagree with this from a UX perspective, but it's come up so often that I figure we should just let users bone themselves.

Main change is in ee0c67e. Cleanup pass in ef10145, including renaming MenuCursorContainer to make its purpose more understandable.

I haven't tested on a touch device, but it should work. Will test later today when I have access to one, if no one beats me.

Touch:

peppy added 2 commits July 26, 2022 14:08
I completely disagree with this from a UX perspective, but it's come up
so often that I figure we should just let users bone themselves.
@smoogipoo
Copy link
Contributor

smoogipoo commented Jul 26, 2022

Is there an issue to reference here for discussion/where discussion has taken place?

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for the time being.

@smoogipoo smoogipoo merged commit 5345e43 into ppy:master Jul 26, 2022
@peppy peppy deleted the cursor-with-touch branch July 28, 2022 08:12
This was referenced Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants