-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate beatmap update flow to handle edge cases better #19378
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ec477a3
Add basic coverage of current behaviour of beatmap reimport
peppy 6a3e8e3
Centralise calls to reset online info of a `BeatmapInfo`
peppy b7f6413
Fix old version of beatmap potentially not being deleted during updat…
peppy 912218e
Ensure scores are transferred after beatmap update if difficulty hash…
peppy e5ad074
Ensure previous version prior to update loses online info after marke…
peppy 2363a3f
Persist `DateAdded` over beatmap updates
peppy 2e14d87
Move implementation of updating a beatmap to `BeatmapImporter`
peppy 92dd1bc
Add test coverage of actual update flow
peppy 8a0c8f5
Fix some realm pieces not being cleaned up
peppy 9c411c2
Fix test nullability assertions
peppy d41ac36
Fix scenario where import is expected to be empty
peppy 7d8a78e
Move tests to own class
peppy 8370ca9
Add `ImportAsUpdate` method to `IModelImporter` to avoid otehr changes
peppy 9939866
Revert one more missed change
peppy 846291d
Refactor new tests to not suck as much as the old importer tests
peppy 4c22b55
Fix incorrect handling if an update is processed with no changes
peppy 1221cb1
Add comprehensive test coverage of update scenarios
peppy ee694c1
Add test coverage of no online ID scenario
peppy 7f75184
Merge branch 'master' into beatmap-update-test
peppy 9173271
Fix new update pathway not actually being used
peppy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to put these in a separate file, but splitting out this test feels like it should be done as a separate pass. There's a lot of helper methods and reorganisation to be done.Scratch that, I already managed to avoid using any dependencies while rewriting these.