Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking off result panel stops skin's applause sound #29207

Open
Drison64 opened this issue Jul 30, 2024 · 1 comment
Open

Clicking off result panel stops skin's applause sound #29207

Drison64 opened this issue Jul 30, 2024 · 1 comment
Labels
area:results audio

Comments

@Drison64
Copy link
Contributor

Type

Cosmetic

Bug description

When using a legacy skin, the applause sound abruptly stops as soon as the result panel is unexpanded. This issue is especially noticeable with skins that feature longer applause sounds, where the abrupt stop is more pronounced.

Steps to Reproduce

  1. Use a skin with long applause skin.
  2. Complete a map to trigger the results panel.
  3. Expand a different score panel.
  4. Notice the applause sound stops immediately.

Possible Solution

I observed that rankApplauseSound is initialized and triggered within AccuracyCircle, which is only visible when the panel is expanded. A potential fix could be to move the applause sound playback responsibility to ResultsScreen. This change could ensure the sound plays completely, independent of the results panel's visibility.

I am willing to assist in testing and implementing this fix. Please let me know if this proposed solution seems viable, or if further discussion is needed.

Screenshots or videos

https://youtu.be/Nopvg06lZgE

Version

2024.727.0-lazer

Logs

compressed-logs.zip
@frenzibyte
Copy link
Member

The playback of the applause sound relies on the introductory accuracy circle animation, which makes it hard to move to ResultsScreen without looking ugly. I would suggest you look into why the sound playback stops playing while expanded, as I would hope the sound should still play so long that the score panel exists on the screen (i.e. as long as the user is in the results screen).

@Drison64 Drison64 mentioned this issue Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:results audio
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix AccuracyCircle sounds stopping when its ScorePanel is contracted Drison64/osu
2 participants
@frenzibyte @Drison64