Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hit Judgements disappear unexpectedly #26801

Closed
tomm13 opened this issue Jan 30, 2024 · 11 comments · Fixed by #26839
Closed

Hit Judgements disappear unexpectedly #26801

tomm13 opened this issue Jan 30, 2024 · 11 comments · Fixed by #26839
Assignees
@bdach
Labels
area:skinning priority:0 Showstopper. Critical to the next release. ruleset/osu!

Comments

@tomm13
Copy link
Contributor

tomm13 commented Jan 30, 2024

Type

Game behaviour

Bug description

Judgements only last one frame

Screenshots or videos

BrokenJudgement.mp4

Version

2024.130.2

Logs

compressed-logs.zip
@bdach
Copy link
Collaborator

bdach commented Jan 30, 2024

Please attach/link skin.

@bdach bdach added missing details Can't move forward without more details from the reporter ruleset/osu! area:skinning labels Jan 30, 2024
@tomm13
Copy link
Contributor Author

tomm13 commented Jan 30, 2024

https://drive.google.com/file/d/1EELdPTJ7yJOFwWm2sNWL1m8woPMq5nDP/view?usp=drive_link

@jwh926
Copy link

jwh926 commented Jan 30, 2024 •
edited
Loading

Same issue here. I think it's a problem with the animation processing, because some skins with no judgement animations have no issues.

skin that have no issues

skin that has some issues

@vatei
Copy link

vatei commented Jan 30, 2024

Same issue here
Skin: https://drive.google.com/file/d/1HouZ-zgopRlzIP8d6K5MAn-anWIsvJJS/view?usp=sharing

I played lazer before and it's an issue with the new update

@alivemaster
Copy link

alivemaster commented Jan 30, 2024 •
edited
Loading

it seems that all skins with animated 100/50/miss have the same issue. The animations look like playing at an unexpected fast speed or interrupted before done playing
Version: 2024.130.2
Skin: https://alivemaster.s-ul.eu/YAT8rw4G

2024-01-30_22-49-16_clip.mp4

@bdach bdach added priority:0 Showstopper. Critical to the next release. and removed missing details Can't move forward without more details from the reporter labels Jan 30, 2024
@cookiemint
Copy link

having the same problem with skins that have animated 100/50/miss

@Sprinter05
Copy link

Same issue here with all judgements using the reOwO Tuna - Selyu skin

@bdach bdach self-assigned this Jan 30, 2024
@innocentDE
Copy link

I've been trying with different skins and it seems to be more often with animated hit judgements

@bdach
Copy link
Collaborator

bdach commented Jan 30, 2024

Thanks everyone, no further input necessary, I can reproduce. I'm investigating why this is happening.

bdach added a commit to bdach/osu that referenced this issue Jan 30, 2024
@bdach
Revert "Move fade more local to avoid fading twice"
c5e118b 
This reverts commit d0421fe
and fixes ppy#26801.

ppy#26703 (comment)
was correct in saying that the early fade-out needs to be restored, and
that's because of the early-return. Legacy judgements that are the
temporary displayed judgement from new piece should also receive the
fade-out, and d0421fe broke that.
@bdach bdach mentioned this issue Jan 30, 2024
Merged
@bdach bdach moved this from Known issues to Working to fix in osu!lazer "pp" release issue tracker Jan 30, 2024
@github-project-automation github-project-automation bot moved this from Working to fix to Fixed in osu!lazer "pp" release issue tracker Jan 31, 2024
@suicidalravioli
Copy link

I will comment, to some degree it is nice to have a shorter judgement period, gives less "nerves" when playing high intensity patterns, perhaps in future allow users to adjust period the judgements show up?

@bdach bdach mentioned this issue Jan 31, 2024
Closed
@NoelleTGS
Copy link

I will comment, to some degree it is nice to have a shorter judgement period, gives less "nerves" when playing high intensity patterns, perhaps in future allow users to adjust period the judgements show up?

Can't this just be adjusted by having less frames in the animation?

This was referenced Jan 31, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:skinning priority:0 Showstopper. Critical to the next release. ruleset/osu!
Projects
osu!lazer "pp" release issue tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix legacy animated judgements not fading out correctly bdach/osu
10 participants
@bdach @alivemaster @tomm13 @NoelleTGS @vatei @innocentDE @suicidalravioli @Sprinter05 @jwh926 @cookiemint