Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict Tracking makes hitting sliders that are next to each other impossible to hit #25816

Closed
SedjamTan opened this issue Dec 18, 2023 · 1 comment · Fixed by #26053
Closed

Strict Tracking makes hitting sliders that are next to each other impossible to hit #25816

SedjamTan opened this issue Dec 18, 2023 · 1 comment · Fixed by #26053
Assignees
@bdach
Labels
area:gameplay priority:1 Very important. Feels bad without fix. Affects the majority of users. ruleset/osu!

Comments

@SedjamTan
Copy link

Type

Game behaviour

Bug description

Tried playing this song with Strict Tracking, it suddenly made the sliders that are next to each other impossible to hit (either one or both of them miss). Additionally, Autoplay miss when Strict Tracking is enabled.

Screenshots or videos

With Strict Tracking:

2023-12-18.15-10-44.mp4

Without Strict Tracking:

2023-12-18.15-12-10.mp4

Version

2023.1218.0-lazer

Logs

1702883017.runtime.log
1702883017.network.log
1702883017.performance.log
1702881549.network.log
1702881549.runtime.log
1702881549.performance.log
1702881549.database.log
@bdach bdach mentioned this issue Dec 19, 2023
Closed
@peppy peppy added ruleset/osu! area:gameplay priority:1 Very important. Feels bad without fix. Affects the majority of users. labels Dec 19, 2023
@ramjam18
Copy link

ramjam18 commented Dec 19, 2023 •
edited
Loading

Can replicate. Thought I was going crazy.

Strict.Tracking.mp4

This was referenced Dec 19, 2023
Closed
Closed
@bdach bdach self-assigned this Dec 22, 2023
bdach added a commit to bdach/osu that referenced this issue Dec 22, 2023
@bdach
Fix strict tracking mod forcefully missing tail before slider start time
30553dc 
Closes ppy#25816.

Regressed in ppy#25748.

The reason this broke is that allowing the state of `Tracking` to change
before the slider's start time to support the early hit scenario causes
strict tracking to consider loss of tracking before the slider's start
time as an actual miss, and thus forcefully miss the tail
(see test case in 6cb8231).
@bdach bdach mentioned this issue Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:gameplay priority:1 Very important. Feels bad without fix. Affects the majority of users. ruleset/osu!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix strict tracking mod forcefully missing tail before slider start time bdach/osu
4 participants
@peppy @bdach @SedjamTan @ramjam18