Merge pull request #11420 from nanaya/karma-container

Add separate container for javascript test
ppy · Aug 15, 2024 · 882588b · 882588b
2 parents 4605df3 + 3b21f83
commit 882588b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/SETUP.md b/SETUP.md
@@ -352,7 +352,7 @@ yarn karma start --single-run
 or if using Docker:
 
 ```
-docker compose run --rm php test js
+docker compose run --rm testjs
 ```
 
 # Documentation

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -47,6 +47,15 @@ services:
     <<: *x-web
     command: ['job']
 
+  testjs:
+    <<: *x-web
+    volumes:
+      - .:/app
+      - .docker/js-build/assets:/app/public/assets
+      - .docker/js-build/builds:/app/resources/builds
+    profiles: ['testjs']
+    command: ['test', 'js']
+
   schedule:
     <<: *x-web
     command: ['schedule']

diff --git a/docker/development/entrypoint.sh b/docker/development/entrypoint.sh
@@ -23,6 +23,7 @@ if [ "$uid" != 0 ]; then
 fi
 
 usermod -d /app/.docker osuweb > /dev/null
+chown -f "${uid}:${gid}" .docker/js-build/assets .docker/js-build/builds
 
 # helper functions
 _rexec() {