Split domain to which LIO requests are directed to envvar #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On several occasions, I've tried to test something involving LIO full-stack and forgot that the LIO helper hardcodes production. Thankfully I never did damage due to the interop secret check, but it's a bit bone-chilling every time. Additionally I believe this situation can't be correct as far as staging is involved, either. Same as the shared interop secret, this envvar is optional in debug (and it missing causes LIO to become a no-op), and required with no default in release.
peppy
approved these changes
Nov 18, 2024
|
mmh, perhaps should've re_used |
|
I guess, although to me |
|
nah, dont think its worth it. on a second thought, it would be a confusing one to override for internal routing as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On several occasions, I've tried to test something involving LIO full-stack and forgot that the LIO helper hardcodes production. Thankfully I never did damage due to the interop secret check, but it's a bit bone-chilling every time. Additionally I believe this situation can't be correct as far as staging is involved, either.
The envvar is
LEGACY_IO_DOMAIN(open to alternative naming suggestions). Same as the shared interop secret, this envvar is optional in debug (and it missing causes LIO to become a no-op), and required with no default and hard-fail on missing in release.cc @ThePooN as requested (for presumed deployment config updates)