Improve throughput of other commands using ProcessPartitioned by allowing transaction and connection sharing
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The partition commands can sometimes partition across millions of items. We can't have each thread's partition lasting for the full span of those items. Easiest solution is to commit every so often.
smoogipoo
reviewed
Nov 1, 2024
| await transaction.CommitAsync(cancellationToken); | ||
| } | ||
| Interlocked.Add(ref totalScores, (ulong)await ScoreProcessor.ProcessUserScoresAsync(userId, RulesetId, conn, transaction, cancellationToken)); | ||
| await transaction.CommitAsync(cancellationToken); |
There was a problem hiding this comment.
Is this intentional? It sounds like this would break things because the transaction would still be in use for the next iteration.
If what you wanted is the transaction length to be 1, then it should probably be a parameter to ProcessPartitioned rather than a const = 50.
There was a problem hiding this comment.
looks like a merge resolution fail
smoogipoo
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more optimisations I made in order to make updating user totals as a batch more efficient.
More details in some commit messages.