Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ongoing text drag selection when user writes to textbox #6328

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

frenzibyte
Copy link
Member

Before:

CleanShot.2024-07-10.at.12.29.07.mp4

After:

CleanShot.2024-07-10.at.12.28.38.mp4

@bdach
Copy link
Collaborator

bdach commented Jul 10, 2024

Looking at other textboxes on windows, I notice that for most textboxes, when dragging, pressing keys will overwrite the current selection and continue typing, until the mouse is moved, at which point drag will select again. Current master also does that.

This changes that behaviour, but for instance, I see VS Code doing the same thing as this does, in that a drag operation gets killed by keyboard input entirely and a new one has to be started to select again.

Code looks correct, and I'm mostly indifferent on the UX, so leaving it to other reviewers to determine if we want this in this form. Maybe this varies per-platform too, not sure.

@bdach bdach requested a review from a team July 10, 2024 11:49
@smoogipoo smoogipoo merged commit ba00c27 into ppy:master Jul 11, 2024
21 checks passed
@frenzibyte frenzibyte deleted the block-drag-wip branch July 11, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fast typing makes issues when changing sample volume
3 participants