Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce allocation overhead for keyboard / binding / button handling #6126

Merged
merged 8 commits into from
Jan 12, 2024

Fix edge case

da75cb6
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Reduce allocation overhead for keyboard / binding / button handling #6126

Fix edge case
da75cb6
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (macOS, MultiThreaded, Debug) failed Jan 12, 2024 in 0s

Test Results (macOS, MultiThreaded, Debug) ❌

Tests failed

❌ TestResults-macOS-MultiThreaded-Debug.trx

3156 tests were completed in 371s with 3076 passed, 1 failed and 79 skipped.

Test suite Passed Failed Skipped Time
osu.Framework.Tests.Clocks.InterpolatingFramedClockTest 7✔️ 1❌ 33s

❌ osu.Framework.Tests.Clocks.InterpolatingFramedClockTest

✔️ CanSeekBackwards
❌ CanSeekForwardsOnInterpolationFail
	  Expected: False
	  But was:  True
	
✔️ InterpolationStaysWithinBounds
✔️ NeverInterpolatesBackwards
✔️ NeverInterpolatesBackwardsOnInterpolationFail
✔️ SourceChangeTransfersValueAdjustable
✔️ SourceChangeTransfersValueNonAdjustable
✔️ TestInterpolationAfterSourceStoppedThenSeeked

Annotations

Check failure on line 178 in osu.Framework.Tests/Clocks/InterpolatingFramedClockTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded, Debug)

osu.Framework.Tests.Clocks.InterpolatingFramedClockTest ► CanSeekForwardsOnInterpolationFail

Failed test found in:
  TestResults-macOS-MultiThreaded-Debug.trx
Error:
    Expected: False
    But was:  True
  
Raw output
  Expected: False
  But was:  True

   at osu.Framework.Tests.Clocks.InterpolatingFramedClockTest.CanSeekForwardsOnInterpolationFail() in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Clocks/InterpolatingFramedClockTest.cs:line 178

1)    at osu.Framework.Tests.Clocks.InterpolatingFramedClockTest.CanSeekForwardsOnInterpolationFail() in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Clocks/InterpolatingFramedClockTest.cs:line 178