Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SpriteIcon #6111

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Simplify SpriteIcon #6111

merged 2 commits into from
Jan 9, 2024

Conversation

EVAST9919
Copy link
Contributor

Closes #6110

As far as I can tell, there's no visual difference (which is desired behaviour).

master pr
tests test-scene-before test-scene-after
test-rotated rotation-before rotation-after
settings settings-before settings-after
song-select song-select-before song-select-after
mods mods-before mods-after

@peppy
Copy link
Member

peppy commented Jan 9, 2024

Weirdly, I brought this up recently during a stream. Not sure if you noticed and took action or just a coincidence, but great to see 😅

@peppy peppy merged commit 126bd17 into ppy:master Jan 9, 2024
19 of 21 checks passed
@EVAST9919 EVAST9919 deleted the icons-shadow branch January 9, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpriteIcons are unnecessary expensive
3 participants