-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set process priority of framework window to high when focused #6104
Conversation
This is something we do on osu!stable and has large gains on desktop systems, especially when shared with other heavy applications.
Have you considered how this may affect headless testing? |
I'm not sure it realistically matters until proven otherwise. Do you have some specific concern in mind? |
My concerns mostly come from the tone of the documentation: "Use extreme care when specifying High for the process's priority class [...]" I've just run the full framework test suite and haven't noticed any slowdowns on my machine, so it's probably fine. |
Linux also fails on lack of permissions (only when attempting to set to high).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems probably fine to me. Let's see how this pans out.
@peppy your call on whether you want to address the tests concern brought up above.
i think it might be best to, but hesitant because I'm not sure how to structure it without thinking for more than a few seconds. |
Probably make osu-framework/osu.Framework/Platform/HeadlessGameHost.cs Lines 94 to 97 in 4fe6df7
That, or move to |
This is something we do on osu!stable and has large gains (for some users) on desktop systems, especially when shared with other heavy applications.
Tested on windows and macOS. Windows works as expected, macOS fails due to lack of permissions. Would appreciate linux testing.
If deemed more appropriate, can be moved to
WindowsGameHost
.