Build debug symbol packages in deploy workflow #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, this should deal with #5695.
Admittedly I haven't tested this end-to-end because it's a little tedious to do so (would have to change default branch on my fork to use these changes, add a secret to push to nuget, change the package IDs around, tag, trigger the workflow...) But, if the docs from nuget and the
upload-artifactaction are to be trusted, this should work? I can go and do the full flow test described above if that is considered a requirement.Note that I haven't changed the final push command, because docs claim the symbols package should be automatically detected. If it turns out they're not, then we can always try adding another push command for the
snupkgs specifically.