Use fully qualified name to ensure uniqueness #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When would lower performance be noticed? After making code changes? |
|
Yeah, the same scenario as when processing files would trigger prior to this. It seems a little bit slower to me but I want your second opinion. |
peppy
added a commit
to smoogipoo/osu-framework
that referenced
this pull request
Nov 25, 2022
|
I've tested on two different PCs and cannot notice the overhead in a meaningful way. I think the CPU usage may be a bit higher but this is definitely usable 👍 . |
peppy
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using fully qualified names seems to stop rider from reprocessing files. @peppy please re-test this. Performance may not be as good as with incremental generator, but still seems acceptable to me.
Using
IIncrementalGeneratorwill take a bit more work.