Silently return rather than throwing when performing mutations on disposed drawables #5534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
force-pushed
the
dont-throw-on-disposed
branch
from
2eb71bf to
d9a554f
Compare
|
There's a couple of test failures I'm unsure about, needs further investigation. |
bdach
reviewed
Nov 22, 2022
bdach
approved these changes
Nov 23, 2022
smoogipoo
approved these changes
Nov 25, 2022
frenzibyte
reviewed
Dec 17, 2022
There was a problem hiding this comment.
Looking at the specific case mentioned in OP, I'm interested to know what's trigging the value change, since a drawable usually unbinds all of its bindables before disposal. But that being said, I can't think of that being potentially bad to cause issues hiding behind us, so I'm not completely against this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common pain point in test and production failures, which isn't really protecting us from incorrect usage. I think it makes more sense not to throw in these scenarios.
Example of a failure: https://github.com/ppy/osu/actions/runs/3511604121/jobs/5882531098
We would usually fix these by adding a
Scheduleinline, but this can potentially cause other unforeseen issues in normal usage (frame delay; events not running due to alive state etc). We've added such schedules in countless places.Interested in thoughts of those marked for review (and anyone else that cares enough). Also please check through each exception to make sure you agree with all the removed ones. I've left some which make sense to keep around.