-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix all remaining OpenGL-specific classes with "GL" in name #5381
Conversation
I'd prefer |
I was under the thought that the “GL” suffix was used to indicate that the class isn’t directly an inheritor of an interface/class with the same name (i.e. Bit of a weak argument though, and I’ve already opted to call the Veldrid one as |
There's nothing special about the naming. I agree with using "GL".
Hmm. We typically don't suffix things in o!f/lazer, as opposed to stable. Between |
Prefix is fine. "Vd" feels weird so I'd prefer using "Veldrid". |
First steps towards supporting Veldrid, need to have all OpenGL-specific classes prefixed with
GL
to not conflict in names with the upcoming Veldrid variants. Few notes:GLLinear{Buffer,Batch}
reads a bit weird given the double L in the name, but not sure if it should be renamed.VideoTexture
has been renamed toVideoTextuerGL
and also been moved to theOpenGL.Textures
namespace, instead of its original place (Videos
).IVertexBuffer
has also been prefixed as it's currently internal and OpenGL-specific, but it could potentially be moved out if we decide to have a baseRenderer
/VertexBatch
class which makes use of this interface.