Properly block SDL IME results sent as multiple text events + upstream SDL fixes #5141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Closes ppy/osu#17231.
SDL will now send multiple
SDL_TEXTINPUT
events when the result is over 32 bytes. Here that is handled by blocking all text events that come in the same event loop. But because valid non-IME text events can arrive in the same event loop, we must check the text matches.Eg. on Korean IME, pressing
t
,h
, then1
: (only"소"
is part of the composition,"1"
is just regular text input)