Add support for nested AudioMixers #4915
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
peppy
reviewed
Dec 15, 2021
| @@ -96,9 +79,13 @@ protected void Remove(IAudioChannel channel, bool moveToParent) | |||
|
|
|||
| #region IAudioChannel | |||
|
|
|||
| public AudioMixer? Mixer { get; } | |||
| public virtual AudioMixer? Mixer { get; set; } | |||
There was a problem hiding this comment.
I can see that this naming is used to match the IAudioChannel interface, but mixer.Mixer = parent reads pretty weird.
There was a problem hiding this comment.
Do you mean the part where it's named Mixer? If so, I tend to agree but not sure of a better name... OutputTarget maybe? but then if it's of type AudioMixer, that's also weird, so...
There was a problem hiding this comment.
Yeah. Not sure on a solution yet.
There was a problem hiding this comment.
How about calling it Parent/ParentMixer and explicitly implement IAudioChannel.Mixer to it:
public AudioMixer? Parent { get; set; }
AudioMixer? IAudioChannel.Mixer => Parent;There was a problem hiding this comment.
I was going to suggest that but for some reason I thought it wouldn't work. I think it's an amicable solution.
…for MacOS 'popping' issue that is known to affect some hardware models when outputting at 32-bit
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is a pre-requisite for applying processing to groupings of audio channels in Lazer, and affords the ability to chain mixers with different processing/effects.
Utilising this capability, a
GlobalMixerhas been added (whichTrackMixerandSampleMixerare now routed into). This will allow for monitoring of the final summed audio output and for any final audio processing to happen just prior to output.