Fix video stopping playback permanent when reaching end of stream #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
peppy
commented
Sep 2, 2021
•
peppy
commented
- Depends on Reduce video decode overhead after reaching end of stream #4749 (mostly for mergeability).
1 task
bdach
previously approved these changes
Sep 2, 2021
bdach
reviewed
Sep 4, 2021
| if (PlaybackPosition < decoder.Duration) | ||
| { | ||
| decoder.Seek(PlaybackPosition); | ||
| availableFrames.Clear(); |
There was a problem hiding this comment.
On a second look, isn't this leaking availableFrames if there are potentially any left? Shouldn't they get returned to the decoder again?
There was a problem hiding this comment.
Yeah good catch. A bit scary this isn't guarded against. Have split this out.
bdach
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.