Bundle of random changes #3
Open
+210
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Spencer <baildon.research@googlemail.com>
Symlinks that are broken return false with '-e' and need to be matched explicitly with '-L'. Signed-off-by: David Spencer <baildon.research@googlemail.com>
Signed-off-by: David Spencer <baildon.research@googlemail.com>
Signed-off-by: David Spencer <baildon.research@googlemail.com>
--exclude-from (-X) reads a list of exclude specs from a file. Exclude specs can optionally specify a package name: <packagename>:<messageid> <packagename> <messageid> The package name must be exact (wildcards not supported, and must not include version/arch/build/tag/.t?z). Essentially, this implements a 'whitelist file'. Signed-off-by: David Spencer <baildon.research@googlemail.com>
Signed-off-by: David Spencer <baildon.research@googlemail.com>
Signed-off-by: David Spencer <baildon.research@googlemail.com>
Add check for 'dir' file, which should not be present. Add check for install-info command in doinst.sh. Tune uncompressed info page check with regex (reduce false +ves). Signed-off-by: David Spencer <baildon.research@googlemail.com>
Signed-off-by: David Spencer <baildon.research@googlemail.com>
Signed-off-by: David Spencer <baildon.research@googlemail.com>
Signed-off-by: David Spencer <baildon.research@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Heinz, many of the changes in this branch are unrelated to each other, so you can cherry-pick the ones you want.
--exclude-from is an idea for implementing a whitelist for specific Slackware packages, there is a separate commit for an example whitelist file.
I'm not sure that I like the suggested architecture check changes. If you don't like them, that's ok :-) but if you do like them I'll add some more sub-checks to make it more useful.