Backwards compatibility of test data with pymatgen #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/more-deps
branch
from
c2ce382 to
65d7990
Compare
ml-evs
force-pushed
the
ml-evs/more-deps
branch
from
65d7990 to
75914bb
Compare
|
Hi @ppdebreuck, I was able to get everything working with the latest pymatgen, so think this is ready to release now. |
ppdebreuck
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #204, our test data is losing compatibility with newer versions, as we used pickle rather than
to_dictto serialize it. In the longer term, we will probably have to regenerate this data or refactor our tests, but for now this PR hot patches the loaded pickles with the required attributes for latest pymatgen versions.This (somewhat bizarrely) allows more matminer featurizers to run successfully, so I had to also allow new features to be added on top of the reference data. This PR also allows the matminer
ignore_errorsarg to be controlled at the level of a featurizer, which is useful for debugging.