Give a meaningful name to the raw disk image. #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppc64le-cloud-bot
added
the
size/S
mkumatag
requested changes
Jan 16, 2024
cmd/image/qcow2ova/qcow2ova.go
Outdated
| @@ -232,7 +232,7 @@ Qcow2 images location: | |||
| return err | |||
| } | |||
|
|
|||
| rawImg := filepath.Join(ovaImgDir, ova.VolNameRaw) | |||
| rawImg := filepath.Join(ovaImgDir, fmt.Sprintf("%s-%s", opt.ImageName, ova.VolNameRaw)) | |||
There was a problem hiding this comment.
Instead of using the same pattern in so many places, you can create a variable here and use it everywhere(same variable can be passed to the CreateTarArchive function as well)
Signed-off-by: Poorna Gottimukkula <Poorna.Gottimukkula1@ibm.com>
Poorna-Gottimukkula1
force-pushed
the
vol-name
branch
from
fccd26b to
b315e8d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, Poorna-Gottimukkula1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised this PR to include additional changes for PR #525
CC: @clnperez