Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the installation instructions with brew #407

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Updated the installation instructions with brew #407

merged 2 commits into from
Mar 14, 2023

Conversation

KeerthanaAP
Copy link
Contributor

@KeerthanaAP KeerthanaAP commented Mar 13, 2023 •
edited
Loading

Fix #406

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2023
mkumatag
mkumatag requested changes Mar 13, 2023
View reviewed changes
README.md Outdated
@@ -9,6 +9,19 @@ This is a tool to help with managing of resources in [IBM Power Systems Virtual
2. Select the latest release and download the relevant binary under the Assets section.
3. Run the `pvsadm --help` command to check the available subcommands and the options.

### OSX Installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets create previous section from release page as another section so that aligns well with OSX installation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw: This is not just osx, I see we are shipping for intel linux as well, lets make if generic like Homebew section and in a note you can mention we are shipping for only Mac(x86&arm) and Linux(x86)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Added a new section Binary for installation using binary and mentioned the supported architecture for brew installation.

@mkumatag mkumatag added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 14, 2023
mkumatag
mkumatag approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KeerthanaAP, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 386dd60 into ppc64le-cloud:main Mar 14, 2023
@KeerthanaAP KeerthanaAP deleted the brew_install_steps branch March 14, 2023 09:21
@KeerthanaAP KeerthanaAP mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@bkhadars bkhadars Awaiting requested review from bkhadars

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the installation instructions with the brew
3 participants
@KeerthanaAP @ppc64le-cloud-bot @mkumatag