-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release darwin/arm64 binaries #368
Conversation
/cc @prb112 @KeerthanaAP |
@mkumatag: GitHub didn't allow me to request PR reviews from the following users: prb112. Note that only ppc64le-cloud members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @yussufsh |
@mkumatag Instead of just release, lets add darwin/arm64 to go build process for all changes as well? Let me create a PR for that. |
Thanks! |
@yussufsh the other PR is merged, wondering if we can merge this one too.. |
@mkumatag that was merged manually to test out the support ticket resolution. I was discussing this with @Rajalakshmi-Girish could you please take a look at #370 (comment) and verify if the bot token has the workflow permission? |
I really doubt if its the permission issue because there are other PRs got merged with the same token |
Not sure if something else changed with the API, but I was able to merge via gh cli once the workflow permission was added to my PAT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Let us test with this one. @mkumatag @Rajalakshmi-Girish
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, yussufsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Seems like it is not merging, the one got created recently #372 got merged without any issue! |
The same old 404 error in the tide log:
|
I have no idea what is happening, lets merge manually for now. |
As per a comment in k8s channel, https://kubernetes.slack.com/archives/CDECRSC5U/p1671110296745109?thread_ts=1653297447.079519&cid=CDECRSC5U |
Fixes: #367