Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release darwin/arm64 binaries #368

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Dec 1, 2022

Fixes: #367

@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2022
@mkumatag
Copy link
Member Author

mkumatag commented Dec 1, 2022

/cc @prb112 @KeerthanaAP

@ppc64le-cloud-bot
Copy link
Contributor

@mkumatag: GitHub didn't allow me to request PR reviews from the following users: prb112.

Note that only ppc64le-cloud members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @prb112 @KeerthanaAP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkumatag
Copy link
Member Author

mkumatag commented Dec 7, 2022

/cc @yussufsh

@yussufsh
Copy link
Contributor

yussufsh commented Dec 8, 2022

@mkumatag Instead of just release, lets add darwin/arm64 to go build process for all changes as well? Let me create a PR for that.

@prb112
Copy link
Contributor

prb112 commented Dec 12, 2022

Thanks!

@mkumatag
Copy link
Member Author

@yussufsh the other PR is merged, wondering if we can merge this one too..

@yussufsh
Copy link
Contributor

@yussufsh the other PR is merged, wondering if we can merge this one too..

@mkumatag that was merged manually to test out the support ticket resolution. I was discussing this with @Rajalakshmi-Girish could you please take a look at #370 (comment) and verify if the bot token has the workflow permission?

@mkumatag
Copy link
Member Author

@yussufsh the other PR is merged, wondering if we can merge this one too..

@mkumatag that was merged manually to test out the support ticket resolution. I was discussing this with @Rajalakshmi-Girish could you please take a look at #370 (comment) and verify if the bot token has the workflow permission?

I really doubt if its the permission issue because there are other PRs got merged with the same token

@yussufsh
Copy link
Contributor

@yussufsh the other PR is merged, wondering if we can merge this one too..

@mkumatag that was merged manually to test out the support ticket resolution. I was discussing this with @Rajalakshmi-Girish could you please take a look at #370 (comment) and verify if the bot token has the workflow permission?

I really doubt if its the permission issue because there are other PRs got merged with the same token

Not sure if something else changed with the API, but I was able to merge via gh cli once the workflow permission was added to my PAT.

Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Let us test with this one. @mkumatag @Rajalakshmi-Girish

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2022
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkumatag
Copy link
Member Author

/lgtm
Let us test with this one. @mkumatag @Rajalakshmi-Girish

Seems like it is not merging, the one got created recently #372 got merged without any issue!

@Rajalakshmi-Girish
Copy link

Seems like it is not merging, the one got created recently #372 got merged without any issue!

The same old 404 error in the tide log:

{"base-sha":"78d6ffdf9473bb9292234465d142ecd5f1767189","branch":"main","component":"tide","controller":"sync","error":"status code 404 not one of [200 405 409], body: {\"message\":\"Not Found\",\"documentation_url\":\"https://docs.github.com/rest/reference/pulls#merge-a-pull-request\"}","file":"k8s.io/test-infra/prow/tide/github.go:274","func":"k8s.io/test-infra/prow/tide.(*GitHubProvider).mergePRs","level":"debug","merge-targets":[368],"msg":"Merge failed.","org":"ppc64le-cloud","pr":368,"repo":"pvsadm","severity":"debug","sha":"f237b7f7f88d3e8d0b26f60d091eec032177c2d2","time":"2022-12-15T06:14:11Z"}

@mkumatag
Copy link
Member Author

Seems like it is not merging, the one got created recently #372 got merged without any issue!

The same old 404 error in the tide log:

{"base-sha":"78d6ffdf9473bb9292234465d142ecd5f1767189","branch":"main","component":"tide","controller":"sync","error":"status code 404 not one of [200 405 409], body: {\"message\":\"Not Found\",\"documentation_url\":\"https://docs.github.com/rest/reference/pulls#merge-a-pull-request\"}","file":"k8s.io/test-infra/prow/tide/github.go:274","func":"k8s.io/test-infra/prow/tide.(*GitHubProvider).mergePRs","level":"debug","merge-targets":[368],"msg":"Merge failed.","org":"ppc64le-cloud","pr":368,"repo":"pvsadm","severity":"debug","sha":"f237b7f7f88d3e8d0b26f60d091eec032177c2d2","time":"2022-12-15T06:14:11Z"}

I have no idea what is happening, lets merge manually for now.

@mkumatag mkumatag merged commit d36b5c2 into ppc64le-cloud:main Dec 15, 2022
@mkumatag mkumatag deleted the release_darwin_arm64 branch December 15, 2022 14:30
@Rajalakshmi-Girish
Copy link

I have no idea what is happening, lets merge manually for now.

As per a comment in k8s channel, https://kubernetes.slack.com/archives/CDECRSC5U/p1671110296745109?thread_ts=1653297447.079519&cid=CDECRSC5U
Merge failure by tide is observed when the PR tries to change files in .github folder
@yussufsh @kishen-v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for darwin/arm64 architecture
5 participants