Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the changes to support the import image across different accounts using accesskey and secretkey #179

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Added the changes to support the import image across different accounts using accesskey and secretkey #179

merged 1 commit into from
Oct 27, 2021

Conversation

bkhadars
Copy link
Contributor

Fixes: #175

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 26, 2021
@ppc64le-cloud-bot ppc64le-cloud-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2021
mkumatag
mkumatag requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few review comments and also fix the CI.

cmd/image/import/import.go Show resolved Hide resolved
cmd/image/import/import.go Show resolved Hide resolved
cmd/image/import/import.go Outdated Show resolved Hide resolved
cmd/image/import/import.go Show resolved Hide resolved
@ppc64le-cloud-bot ppc64le-cloud-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2021
@bkhadars bkhadars requested a review from mkumatag October 27, 2021 09:59
mkumatag
mkumatag approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bkhadars make sure you create GH issues for all the outstanding issues we discussed during the PR review.

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bkhadars, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 2262af1 into ppc64le-cloud:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to import images to powerVS instance
3 participants
@bkhadars @ppc64le-cloud-bot @mkumatag