Introduce storage tier variable set to tier-1 by default

[kishen-v]

Observed that the storage-tier used in the periodic jobs is tier-3, which compromises on IO.
Setting the same to tier1 for improved performance.

Validated the changes with an end-to-end test.

  + resource "ibm_pi_instance" "pvminstance" {
...
      + pi_storage_type                = "tier1"
      + pi_sys_type                    = "s922"
...

[kishen-v]

cc: @Rajalakshmi-Girish

[Rajalakshmi-Girish]

@kishen-v I hope this won't change the results for jobs where performance doesn't matter.

@mkumatag, do you think we might need a flag for this?

[kishen-v]

Hi @Rajalakshmi-Girish, there should be no impact imo.
In fact, it seems that the jobs which were earlier running with a Tier-1 volume are now deployed with Tier-3, this change should get things back running with a Tier-1 disk, as earlier.

[Rajalakshmi-Girish]

In fact, it seems that the jobs which were earlier running with a Tier-1 volume are now deployed with Tier-3, this change should get things back running with a Tier-1 disk, as earlier.

Yes could see some changes a few months back to default to tier3 IBM-Cloud/terraform-provider-ibm#5050

[mkumatag]

@kishen-v I hope this won't change the results for jobs where performance doesn't matter.

@mkumatag, do you think we might need a flag for this?

Lets not add any flags at the moment, lets use this default one for now.

[Rajalakshmi-Girish]

/lgtm

[mkumatag]

/lgtm

[ppc64le-cloud-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment