Vector.__reduce__: Do not invoke __new__ directly #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a violation of the [protocol] for object construction: > If __new__ returns an instance of cls, then the new instance’s __init__() > method will be invoked like __init__(self[, ...]), where self is the new > instance and the remaining arguments are the same as were passed to __new__. [protocol]: https://docs.python.org/3/reference/datamodel.html#object.__new__
3 tasks
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 24, 2019
157: Vector.__reduce__: Do not invoke __new__ directly r=astronouth7303 a=nbraud This fixes a violation of the [protocol] for object construction: > If `__new__` returns an instance of `cls`, then the new instance’s `__init__()` method will be invoked like `__init__(self[, ...])`, where `self` is the new instance and the remaining arguments are the same as were passed to `__new__`. [protocol]: https://docs.python.org/3/reference/datamodel.html#object.__new__ @astronouth7303 seems [in agreement](#146 (comment)) Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a violation of the protocol for object construction:
@astronouth7303 seems in agreement