Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expectations of subclasses #144

Closed
wants to merge 24 commits into from
Closed

Update expectations of subclasses #144

wants to merge 24 commits into from

Commits on Apr 15, 2019

  1. tests/ctor: Test that vectors can be copied

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    b28e079 View commit details
    Browse the repository at this point in the history

  2. Vector2: Move most of the initialisation logic back to __init__

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    dbce3f6 View commit details
    Browse the repository at this point in the history

  3. tests/ctor: Generalize copy test to (simple) Vector2 subclasses

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    f378e75 View commit details
    Browse the repository at this point in the history

  4. docs: Introduce a subclassing section, document status-quo

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    4601002 View commit details
    Browse the repository at this point in the history

  5. Propose a generalised support of subclasses, document & test

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    a8118d4 View commit details
    Browse the repository at this point in the history

  6. Vector2: Support subclasses that define extra attributes 

    Weaken the subclassing guarantees: returned vectors now have the type of `self`.
    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    f62f2a8 View commit details
    Browse the repository at this point in the history

  7. Subclasses of Vector2 that define attributes must be dataclasses

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    ac2f2af View commit details
    Browse the repository at this point in the history

  8. tests/subclass: Add missing assumptions 

    Some methods do not accept arbitrary vectors or scalars.
Make sure we only generate inputs in their domain.
    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    252e107 View commit details
    Browse the repository at this point in the history

  9. vector2: Remove vector2._find_lowest_*, now unused

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    9d69fc2 View commit details
    Browse the repository at this point in the history

  10. docs: Improve inheritance documentation

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    4fe19d7 View commit details
    Browse the repository at this point in the history

  11. Document and test the use of __slots__ for subclasses

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    84f241e View commit details
    Browse the repository at this point in the history

  12. tests/subvlass: Work around mypy being unable to typecheck this

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    eed7c03 View commit details
    Browse the repository at this point in the history

  13. tests/subclass: Check that instances of the subclass can be copied 

    See ppb#146
    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    b82c907 View commit details
    Browse the repository at this point in the history

  14. tests/subclass: Add pickling test 

    See ppb#147
    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    d72cc51 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'tests/copy' into subclass

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    de471f0 View commit details
    Browse the repository at this point in the history

  16. tests/utils: Freeze all the operators sets

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    7263661 View commit details
    Browse the repository at this point in the history

  17. fixup! Propose a generalised support of subclasses, document & test

    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    6d8907c View commit details
    Browse the repository at this point in the history

  18. tests/subclass: Update subclasses expectations after __init__ refacto… 

    …r [WIP]
    @nbraud
    nbraud committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    dbf1e5d View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. fixup! Vector2: Move most of the initialisation logic back to __init__

    @nbraud
    nbraud committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    5ce699d View commit details
    Browse the repository at this point in the history

  2. fixup! fixup! Propose a generalised support of subclasses, document &… 

    … test
    @nbraud
    nbraud committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    bc52e47 View commit details
    Browse the repository at this point in the history

  3. fixup! Vector2: Move most of the initialisation logic back to __init__

    @nbraud
    nbraud committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    d5c7163 View commit details
    Browse the repository at this point in the history

  4. fixup! tests/subclass: Update subclasses expectations after __init__ … 

    …refactor [WIP]
    @nbraud
    nbraud committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    f959712 View commit details
    Browse the repository at this point in the history

  5. tests/utils: Freeze all the operators sets

    @nbraud
    nbraud committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    c989b23 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'tests/copy' into subclass

    @nbraud
    nbraud committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    ab69435 View commit details
    Browse the repository at this point in the history