Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows using empty strings in the SLD multi-subs matrix parameter #806

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

CBiasuzzi
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #715

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

…rameter

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi CBiasuzzi requested a review from So-Fras July 18, 2024 17:16
Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fix!

@HugoKulesza HugoKulesza merged commit ec21505 into main Jul 31, 2024
6 checks passed
@HugoKulesza HugoKulesza deleted the fix_multi_subs_diagrams_empty_spots branch July 31, 2024 08:49
geofjamg pushed a commit that referenced this pull request Aug 24, 2024
…rameter (#806)

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
geofjamg pushed a commit that referenced this pull request Aug 27, 2024
…rameter (#806)

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow empty spots on matrix multi-substation diagrams
3 participants