Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI fixed and add basic import test step in CI #760

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Conversation

EtienneLt
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@EtienneLt EtienneLt force-pushed the try-tofix-ci-again branch from e91c23f to 61ed40e Compare June 7, 2024 13:45
@EtienneLt EtienneLt closed this Jun 10, 2024
@EtienneLt EtienneLt force-pushed the try-tofix-ci-again branch from 61ed40e to d0eb810 Compare June 10, 2024 06:56
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt reopened this Jun 10, 2024
EtienneLt and others added 3 commits June 10, 2024 09:16
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix
Copy link
Member

obrix commented Jun 12, 2024

Maybe linked to the following issue : actions/runner-images#10020

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@EtienneLt
Copy link
Contributor Author

it seems to work

@obrix
Copy link
Member

obrix commented Jun 12, 2024

Yes, I think we will be able to remove the workaround once they fix their runner image.
Also I added a simple standalone_test.py that only import powsybl and print version to run before the full tests. That was just to debug at first but I am wondering if it could be a good idea to let it in place to be able to quickly see if an issue is related to the whole import and init of pypowsybl or a to a specific test.
Any opinion @EtienneLt @geofjamg ?

This reverts commit 914794a.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix obrix force-pushed the try-tofix-ci-again branch from 16994fa to bd9ad38 Compare June 12, 2024 19:45
@obrix
Copy link
Member

obrix commented Jun 13, 2024

It looks like the windows image has been fixed.

obrix added 2 commits June 13, 2024 10:15
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix obrix self-requested a review June 13, 2024 08:40
@obrix obrix changed the title try to fix ci issue Windows CI fixed and add basic import tests step in CI Jun 13, 2024
@obrix obrix changed the title Windows CI fixed and add basic import tests step in CI Windows CI fixed and add basic import test step in CI Jun 13, 2024
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix obrix merged commit ff0a045 into main Jun 13, 2024
6 checks passed
@obrix obrix deleted the try-tofix-ci-again branch June 13, 2024 08:59
EtienneLt added a commit that referenced this pull request Jun 14, 2024
* test ci

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>

* Test python 3.10.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* Restore 3.8 and add standalone.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* Try suggested workaround.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* Revert "Try suggested workaround."

This reverts commit 914794a.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* basic import test in CI.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* Remove added line.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* Clean.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

---------

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Co-authored-by: Bertrand Rix <bertrand.rix@artelys.com>
EtienneLt added a commit that referenced this pull request Jun 17, 2024
* test ci

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>

* Test python 3.10.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* Restore 3.8 and add standalone.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* Try suggested workaround.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* Revert "Try suggested workaround."

This reverts commit 914794a.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* basic import test in CI.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* Remove added line.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

* Clean.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

---------

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Co-authored-by: Bertrand Rix <bertrand.rix@artelys.com>
geofjamg added a commit that referenced this pull request Jun 18, 2024
Co-authored-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants