Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shunt dynamic models #360

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Add Shunt dynamic models #360

merged 5 commits into from
Jul 2, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Jun 5, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

The only model implemented for Shunt dynamic model is the default one.

What is the new behavior (if this is a feature change)?
Add Shunt dynamic models

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte marked this pull request as draft June 5, 2024 15:12
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: Lisrte <laurent.issertial@rte-france.com>
Add documentation

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte marked this pull request as ready for review June 27, 2024 11:34
@Lisrte Lisrte requested a review from flo-dup June 27, 2024 11:35
Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@flo-dup flo-dup merged commit 93ea4ad into main Jul 2, 2024
5 of 6 checks passed
@flo-dup flo-dup deleted the shunt_dynamic_models branch July 2, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants