Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline export mode #351

Merged
merged 2 commits into from
May 23, 2024
Merged

Timeline export mode #351

merged 2 commits into from
May 23, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented May 22, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes partially #307

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte requested a review from flo-dup May 22, 2024 13:27
Copy link

sonarcloud bot commented May 22, 2024

Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't close the #307 issue as you didn't handle the output folder property.

@@ -122,6 +140,9 @@ public static DynaWaltzParameters load(PlatformConfig platformConfig, FileSystem

DumpFileParameters dumpFileParameters = new DumpFileParameters(exportDumpFile, useDumpFile, exportDumpFileFolderPath, dumpFile);

// Timeline export mode
ExportMode timelineExport = config.flatMap(c -> c.getOptionalEnumProperty("timeline.exportMode", ExportMode.class)).orElse(DEFAULT_TIMELINE_EXPORT_MODE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep in mind to write somewhere all the properties which can be set for dynawaltz - it has been decided today to use readthedocs for all powsybl repositories.

@flo-dup flo-dup merged commit 81ae3a2 into main May 23, 2024
6 checks passed
@flo-dup flo-dup deleted the timeline_export_mode branch May 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants