Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add private config in SynchronizedGeneratorGroovyExtension #250

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Add private config in SynchronizedGeneratorGroovyExtension #250

merged 2 commits into from
Jun 21, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Jun 13, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@Lisrte Lisrte self-assigned this Jun 13, 2023
@Lisrte Lisrte force-pushed the private_synchronized_gen_groovy_config branch from 8617102 to 03e96fb Compare June 13, 2023 14:41
Base automatically changed from add_dangling_hvdc_models to main June 20, 2023 19:51
@geofjamg
Copy link
Member

@Lisrte could you sync it with main?

@Lisrte
Add private config in SynchronizedGeneratorGroovyExtension
a5aeb28 
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte force-pushed the private_synchronized_gen_groovy_config branch 2 times, most recently from 4eb5495 to a5aeb28 Compare June 21, 2023 10:10
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@geofjamg geofjamg merged commit b6633c1 into main Jun 21, 2023
@geofjamg geofjamg deleted the private_synchronized_gen_groovy_config branch June 21, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautierbureau gautierbureau gautierbureau approved these changes

@flo-dup flo-dup flo-dup approved these changes

Assignees

@Lisrte Lisrte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lisrte @geofjamg @gautierbureau @flo-dup