Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Storage Connection [MaxVolSupport] #67

Closed
wants to merge 2 commits into from
Closed

Conversation

michaelkad
Copy link
Collaborator

@michaelkad michaelkad commented Feb 26, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

=== RUN   TestAccIBMPIInstancesDataSource_basic
--- PASS: TestAccIBMPIInstancesDataSource_basic (74.59s)
PASS

=== RUN   TestAccIBMPIInstanceDataSource_basic
--- PASS: TestAccIBMPIInstanceDataSource_basic (73.94s)
PASS

=== RUN   TestAccIBMPIInstanceStorageConnection
--- PASS: TestAccIBMPIInstanceStorageConnection (536.56s)
PASS

Diptipowervs
Diptipowervs previously approved these changes Feb 27, 2024
@ismirlia
Copy link
Collaborator

ismirlia commented Apr 8, 2024

Does the storageConnection not need to be added to the resource instance as an argument as well? It is currently an argument to the instance create command in the CLI.

--storage-connection string                 The storage connection type. Valid values are "vSCSI" or "maxVolumeSupport".

@ismirlia
Copy link
Collaborator

ismirlia commented Apr 9, 2024

Oh the storage connection property is there in the resource, but not the new value. @michaelkad

			helpers.PIInstanceStorageConnection: {
				Type:         schema.TypeString,
				Optional:     true,
				ValidateFunc: validate.ValidateAllowedStringValues([]string{"vSCSI"}),
				Description:  "Storage Connectivity Group for server deployment",
			},

@michaelkad michaelkad changed the title Add Storage Connection to data sources [Datasource]Add Storage Connection to data sources Apr 12, 2024
@michaelkad michaelkad requested review from Diptipowervs and ismirlia and removed request for Diptipowervs and ismirlia April 15, 2024 17:35
@michaelkad michaelkad force-pushed the strorage-conn branch 2 times, most recently from 2ad486a to 5f16791 Compare April 24, 2024 17:19
@michaelkad michaelkad changed the title [Datasource]Add Storage Connection to data sources Update Storage Connection May 6, 2024
@michaelkad michaelkad force-pushed the strorage-conn branch 2 times, most recently from 6d5b94c to 6c09d93 Compare May 8, 2024 14:31
@michaelkad michaelkad changed the title Update Storage Connection Update Storage Connection [MaxVolSupport] Jun 18, 2024
@michaelkad michaelkad added Q3 and removed Q2 labels Jun 18, 2024
@michaelkad michaelkad force-pushed the strorage-conn branch 4 times, most recently from 74fe55f to aca5908 Compare September 19, 2024 20:16
@ismirlia
Copy link
Collaborator

Opened IBM-Cloud#5667, closing this one.

@ismirlia ismirlia closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants