Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detach volume #58

Closed
wants to merge 4 commits into from
Closed

Add detach volume #58

wants to merge 4 commits into from

Conversation

Diptipowervs
Copy link
Collaborator

This in response to: #57

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@michaelkad
Copy link
Collaborator

After looking carefully at the code, I think we don't have to change this because it is tightly couple. We will have to have a new detach. I think we have to close this.

@Diptipowervs
Copy link
Collaborator Author

Close PR

1 similar comment
@Diptipowervs
Copy link
Collaborator Author

Close PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkad michaelkad Awaiting requested review from michaelkad

@ismirlia ismirlia Awaiting requested review from ismirlia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Diptipowervs @michaelkad @ismirlia