Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dhcp and dhcps data source and documentation #27

Closed
wants to merge 6 commits into from
Closed

Refactor dhcp and dhcps data source and documentation #27

wants to merge 6 commits into from

Conversation

Diptipowervs
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@Diptipowervs Diptipowervs changed the title Dhcp refactor Catalog refactor dhcp data source and documentation Dec 29, 2023
@Diptipowervs Diptipowervs changed the title Catalog refactor dhcp data source and documentation Refactor dhcp data source and documentation Dec 31, 2023
@ismirlia ismirlia changed the title Refactor dhcp data source and documentation Refactor dhcp and dhcps data source and documentation Jan 2, 2024
ismirlia
ismirlia previously approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@ismirlia ismirlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, wait for Michael's approval before opening PR in main terraform provider repo.

ismirlia
ismirlia previously approved these changes Jan 10, 2024
View reviewed changes
michaelkad
michaelkad previously approved these changes Jan 17, 2024
View reviewed changes
@ismirlia ismirlia dismissed stale reviews from michaelkad and themself via 80dcdb1 January 30, 2024 15:48
@Diptipowervs
Copy link
Collaborator Author

PR opened in main repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkad michaelkad michaelkad left review comments

@ismirlia ismirlia ismirlia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Diptipowervs @michaelkad @ismirlia