Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor datacenter and datacenters data source and documentation #26

Closed
wants to merge 4 commits into from

Conversation

Diptipowervs
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@Diptipowervs Diptipowervs changed the title datacenter Catalog Refactor datacenter data source and documentation Dec 29, 2023
@Diptipowervs Diptipowervs changed the title Catalog Refactor datacenter data source and documentation Refactor datacenter data source and documentation Dec 31, 2023
@ismirlia ismirlia changed the title Refactor datacenter data source and documentation Refactor datacenter and datacenters data source and documentation Jan 2, 2024
ismirlia
ismirlia previously approved these changes Jan 3, 2024
@ismirlia
Copy link
Collaborator

ismirlia commented Jan 3, 2024

Changes look good, wait for Michael's approval before opening PR in main terraform provider repo.

ismirlia
ismirlia previously approved these changes Jan 10, 2024
michaelkad
michaelkad previously approved these changes Jan 17, 2024
@ismirlia ismirlia dismissed stale reviews from michaelkad and themself via 3cf945f January 30, 2024 15:38
@Diptipowervs
Copy link
Collaborator Author

PR opened in main

@michaelkad michaelkad deleted the data-center-refactor branch May 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants