Refactor powervs terraform data sources and documentation #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files are included in this PR because they had their previous constant variables removed and the code will not compile otherwise.
ismirlia
force-pushed
the
constant-refactor
branch
from
dc9aeea
to
5c81458
Compare
|
@ismirlia we have to break this into multiple PR for the ease of reviewing it. I will be breaking it into different PRs these week |
michaelkad
requested changes
Mar 8, 2024
|
Yea I think all the data source refactor PRs have been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors all data sources, their tests and documentation to be more neat and maintainable.