Refactor deprecated fields and messages #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated fields and messages are wildly inconsistent. Several deprecated fields are not marked as such and the documention is not laid out consistently. This commit should bring them all in line.
michaelkad
requested changes
Jan 2, 2024
There was a problem hiding this comment.
@ismirlia Deprecating field should be remove since we have had the deprecated for a while and if Service Broker doesn't support them anymore. If SB still has support for them, then we should list them as deprecated.
|
Ok let's have this PR remove these fields then. |
|
According to the code the entire ibm_pi_network_port resource is deprecated in favor of the ibm_pi_network_port_attach resource. Can I just go ahead and remove those files also? @michaelkad |
…bm/terraform-provider-ibm into deprecated-message-consistency
|
Opened this in the main terraform repo so closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated fields and messages are wildly inconsistent. Several deprecated fields are not marked as such and the documentation is not laid out consistently. This pull request should bring them all in line.