Private datacenter capabilities #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Kita
force-pushed
the
private-datacenter-capabilities
branch
from
5717eb8
to
6bc4785
Compare
michaelkad
reviewed
Oct 15, 2024
Comment on lines
+188
to
+199
|
|
||
| var client *instance.IBMPIDatacentersClient | ||
| if !sess.IsOnPrem() { | ||
| client = instance.NewIBMPIDatacenterClient(ctx, sess, "") | ||
| } else { | ||
| if cloudInstanceId, ok := d.GetOk(Arg_CloudInstanceID); ok { | ||
| client = instance.NewIBMPIDatacenterClient(ctx, sess, cloudInstanceId.(string)) | ||
| } else { | ||
| return diag.Errorf("must provide %s if the datacenter is private/on-prem", Arg_CloudInstanceID) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you update it so the on premise check is done in the sdk and only have
var cloudInstance := ""
if cloudInstanceId, ok := d.GetOk(Arg_CloudInstanceID); ok {
cloudInstance = cloudInstance
}
client = instance.NewIBMPIDatacenterClient(ctx, sess, cloudInstance)
And update the doc to say the instanceID is required if onprem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing:
pi_datacenters (d)
pi_datacenters (d)