Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Granular CRN for image datasources and resources #164

Closed
wants to merge 18 commits into from
Closed

Granular CRN for image datasources and resources #164

wants to merge 18 commits into from

Conversation

Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Aug 20, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_catalog_images (d):

=== RUN   TestAccIBMPICatalogImagesDataSourceBasic
--- PASS: TestAccIBMPICatalogImagesDataSourceBasic (52.36s)
PASS

=== RUN   TestAccIBMPICatalogImagesDataSourceVTL
--- PASS: TestAccIBMPICatalogImagesDataSourceVTL (51.41s)
PASS

=== RUN   TestAccIBMPICatalogImagesDataSourceSAP
--- PASS: TestAccIBMPICatalogImagesDataSourceSAP (74.17s)
PASS

=== RUN   TestAccIBMPICatalogImagesDataSourceSAPAndVTL
--- PASS: TestAccIBMPICatalogImagesDataSourceSAPAndVTL (61.02s)
PASS

pi_image (d):

=== RUN   TestAccIBMPIImageDataSource_basic
--- PASS: TestAccIBMPIImageDataSource_basic (17.08s)
PASS

pi_images (d):

=== RUN   TestAccIBMPIImagesDataSource_basic
--- PASS: TestAccIBMPIImagesDataSource_basic (28.87s)
PASS

pi_image (r):

=== RUN   TestAccIBMPIImagebasic
--- PASS: TestAccIBMPIImagebasic (40.15s)
PASS

(Used private bucket)

=== RUN   TestAccIBMPIImageCOSPublicImport
--- PASS: TestAccIBMPIImageCOSPublicImport (1227.62s)
PASS

=== RUN   TestAccIBMPIImageBYOLImport
--- PASS: TestAccIBMPIImageBYOLImport (1817.78s)
PASS

@Alexander-Kita Alexander-Kita self-assigned this Aug 20, 2024
michaelkad
michaelkad requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.

@Alexander-Kita Alexander-Kita marked this pull request as ready for review August 30, 2024 16:52
@michaelkad michaelkad added the Q3 label Sep 13, 2024
@Alexander-Kita
Copy link
Collaborator Author

Opened in main repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkad michaelkad michaelkad approved these changes

@ismirlia ismirlia ismirlia approved these changes

Assignees

@Alexander-Kita Alexander-Kita

Labels
Datasource Q3 Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexander-Kita @michaelkad @ismirlia