Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular CRN for network datasources and resources #162

Closed
wants to merge 16 commits into from

Conversation

Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Aug 20, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_network (d):

=== RUN   TestAccIBMPINetworkDataSource_basic
--- PASS: TestAccIBMPINetworkDataSource_basic (12.23s)
PASS

pi_networks (d):

=== RUN   TestAccIBMPINetworksDataSource_basic
--- PASS: TestAccIBMPINetworksDataSource_basic (11.58s)
PASS

pi_public_network (d):

=== RUN   TestAccIBMPIPublicNetworkDataSource_basic
--- PASS: TestAccIBMPIPublicNetworkDataSource_basic (9.65s)
PASS

pi_network (r):

=== RUN   TestAccIBMPINetworkbasic
--- PASS: TestAccIBMPINetworkbasic (57.95s)
PASS
=== RUN   TestAccIBMPINetworkGatewaybasic
--- PASS: TestAccIBMPINetworkGatewaybasic (77.08s)
PASS
=== RUN   TestAccIBMPINetworkDHCPbasic
--- PASS: TestAccIBMPINetworkDHCPbasic (65.87s)
PASS

pi_network_port_attach (r):

=== RUN   TestAccIBMPINetworkPortAttachVlanbasic
--- PASS: TestAccIBMPINetworkPortAttachVlanbasic (63.98s)
PASS

Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments

@Alexander-Kita Alexander-Kita marked this pull request as ready for review September 5, 2024 14:02
@michaelkad michaelkad added the Q3 label Sep 13, 2024
@Alexander-Kita
Copy link
Collaborator Author

Opened in main repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants