forked from IBM-Cloud/terraform-provider-ibm
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular CRN for shared processor pool data sources and resources #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkad
reviewed
Aug 21, 2024
michaelkad
reviewed
Aug 21, 2024
michaelkad
reviewed
Aug 21, 2024
ibm/service/power/resource_ibm_pi_shared_processor_pool_test.go
Outdated
Show resolved
Hide resolved
michaelkad
reviewed
Aug 21, 2024
ibm/service/power/resource_ibm_pi_shared_processor_pool_test.go
Outdated
Show resolved
Hide resolved
michaelkad
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments
ismirlia
reviewed
Aug 26, 2024
ismirlia
reviewed
Aug 26, 2024
ismirlia
approved these changes
Aug 26, 2024
ismirlia
approved these changes
Aug 30, 2024
michaelkad
reviewed
Sep 6, 2024
ibm/service/power/resource_ibm_pi_shared_processor_pool_test.go
Outdated
Show resolved
Hide resolved
michaelkad
approved these changes
Sep 6, 2024
michaelkad
approved these changes
Sep 13, 2024
Co-authored-by: ismirlia <90468712+ismirlia@users.noreply.github.com>
Alexander-Kita
force-pushed
the
crn-spp
branch
from
September 17, 2024 19:24
89d337c
to
843ba08
Compare
Opened in main repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing:
pi_shared_processor_pool (d):
pi_shared_processor_pools (d):
pi_shared_processor_pool (r):