Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasource, Resource] Network Address Groups, Member #153

Closed
wants to merge 1 commit into from
Closed

[Datasource, Resource] Network Address Groups, Member #153

wants to merge 1 commit into from

Conversation

michaelkad
Copy link
Collaborator

@michaelkad michaelkad commented Aug 9, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPINetworkAddressGroupsDataSourceBasic
--- PASS: TestAccIBMPINetworkAddressGroupsDataSourceBasic (15.36s)
PASS

=== RUN   TestAccIBMPINetworkAddressGroupDataSourceBasic
--- PASS: TestAccIBMPINetworkAddressGroupDataSourceBasic (18.07s)
PASS

=== RUN   TestAccIBMPINetworkAddressGroupBasic
--- PASS: TestAccIBMPINetworkAddressGroupBasic (35.26s)
PASS

=== RUN   TestAccIBMPINetworkAddressGroupMemberBasic
--- PASS: TestAccIBMPINetworkAddressGroupMemberBasic (50.40s)
PASS

@michaelkad michaelkad changed the title [Datasource] network address groups [Datasource] Network Address Groups Aug 9, 2024
@michaelkad michaelkad changed the title [Datasource] Network Address Groups [Datasource][Resource] Network Address Groups Aug 12, 2024
@michaelkad michaelkad changed the title [Datasource][Resource] Network Address Groups [Datasource, Resource] Network Address Groups Aug 13, 2024
@michaelkad michaelkad force-pushed the network-address-groups-d branch 2 times, most recently from bac27ad to 819029f Compare August 13, 2024 21:39
@michaelkad michaelkad force-pushed the network-address-groups-d branch 3 times, most recently from 49f8258 to 8fdc035 Compare August 13, 2024 22:00
@michaelkad michaelkad changed the title [Datasource, Resource] Network Address Groups [Datasource, Resource] Network Address Groups, Member Sep 6, 2024
@ismirlia ismirlia added the Q4 label Sep 23, 2024
@ismirlia
Copy link
Collaborator

Should there be a UserTag Attribute as part of the list data source in the NAG?

@michaelkad
Copy link
Collaborator Author 

=== RUN   TestAccIBMPINetworkAddressGroupBasic
--- PASS: TestAccIBMPINetworkAddressGroupBasic (38.50s)
PASS

=== RUN   TestAccIBMPINetworkAddressGroupMemberBasic
--- PASS: TestAccIBMPINetworkAddressGroupMemberBasic (52.32s)
PASS

=== RUN   TestAccIBMPINetworkAddressGroupDataSourceBasic
--- PASS: TestAccIBMPINetworkAddressGroupDataSourceBasic (18.30s)
PASS

=== RUN   TestAccIBMPINetworkAddressGroupsDataSourceBasic
--- PASS: TestAccIBMPINetworkAddressGroupsDataSourceBasic (16.49s)
PASS

ismirlia
ismirlia previously approved these changes Oct 14, 2024
View reviewed changes
@michaelkad
Copy link
Collaborator Author

Opened in main repo

@michaelkad michaelkad closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexander-Kita Alexander-Kita Awaiting requested review from Alexander-Kita

@ismirlia ismirlia Awaiting requested review from ismirlia

Assignees
No one assigned
Labels
Datasource Q4 Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelkad @ismirlia @Alexander-Kita