Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GRS Attributes/Arguments to pi_volume resource #150

Closed
wants to merge 14 commits into from
Closed

Add GRS Attributes/Arguments to pi_volume resource #150

wants to merge 14 commits into from

Conversation

Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Aug 6, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPIVolumebasic
--- PASS: TestAccIBMPIVolumebasic (85.61s)
PASS

=== RUN   TestAccIBMPIVolumePool
--- PASS: TestAccIBMPIVolumePool (45.81s)
PASS

=== RUN   TestAccIBMPIVolumeGRS
--- PASS: TestAccIBMPIVolumeGRS (75.89s)
PASS

=== RUN   TestAccIBMPIVolumeUpdate
--- PASS: TestAccIBMPIVolumeUpdate (47.67s)
PASS

Description:
Added pi_replication_sites argument and replication_sites attribute to pi_volume resource.

@Alexander-Kita Alexander-Kita self-assigned this Aug 6, 2024
@Alexander-Kita Alexander-Kita changed the title Add GRS to pi_volume resource Add GRS to Attributes/Arguments pi_volume resource Aug 6, 2024
@Alexander-Kita Alexander-Kita changed the title Add GRS to Attributes/Arguments pi_volume resource Add GRS Attributes/Arguments to pi_volume resource Aug 6, 2024
@Alexander-Kita Alexander-Kita added Resource enhancement New feature or request and removed enhancement New feature or request labels Aug 8, 2024
@Alexander-Kita
Copy link
Collaborator Author

@michaelkad Re-requesting review for replication sites attribute checking

Alexander-Kita added a commit that referenced this pull request Aug 27, 2024
@Alexander-Kita
fixes from #150
4897a1d
@Alexander-Kita Alexander-Kita mentioned this pull request Aug 27, 2024
Closed
Alexander-Kita added a commit that referenced this pull request Aug 27, 2024
@Alexander-Kita
fixes from #150
665b8de
michaelkad
michaelkad approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaelkad michaelkad added the Q3 label Sep 13, 2024
Alexander-Kita added a commit that referenced this pull request Sep 19, 2024
@Alexander-Kita
fixes from #150
fb8cd5f
Alexander-Kita added a commit that referenced this pull request Sep 23, 2024
@Alexander-Kita
fixes from #150
a8815df
@Alexander-Kita
Copy link
Collaborator Author

Opened in main repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkad michaelkad michaelkad approved these changes

@ismirlia ismirlia ismirlia approved these changes

Assignees

@Alexander-Kita Alexander-Kita

Labels
Q3 Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexander-Kita @michaelkad @ismirlia