VMRM

[michaelkad]

• Add VM no storage to deployment type

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX’
=== RUN   TestAccIBMPIInstanceDeploymentTypeNoStorage
--- PASS: TestAccIBMPIInstanceDeploymentTypeNoStorage (482.04s)
PASS
...

[dhirendersingh19]

@michaelkad , could you please add a test case for a VM without storage? I believe when we create a VM without storage, its status is set to the Shutoff state. In our logic, the isWaitForPIInstanceAvailablefunction checks for the VM to be in the ACTIVE state. It's important to verify the status of a VM when deploying it without storage to ensure it is in the Shutoff state.

I cannot find the test case TestAccIBMPIInstanceDeploymentTypeNoStorage in the file resource_ibm_pi_instance_test.go.

[michaelkad]

@michaelkad , could you please add a test case for a VM without storage? I believe when we create a VM without storage, its status is set to the Shutoff state. In our logic, the isWaitForPIInstanceAvailablefunction checks for the VM to be in the ACTIVE state. It's important to verify the status of a VM when deploying it without storage to ensure it is in the Shutoff state.

I cannot find the test case TestAccIBMPIInstanceDeploymentTypeNoStorage in the file resource_ibm_pi_instance_test.go.

Yes, you are right. I thought I pushed that code. I just included it.

[michaelkad]

It has been open in the main repo already.